From 034e5a0142c3704645befc8f27a04a061a81156d Mon Sep 17 00:00:00 2001
From: Xavier Guimard <xavier.guimard@laposte.net>
Date: Tue, 11 May 2010 07:09:10 +0000
Subject: [PATCH] Some little things

---
 .../lib/Lemonldap/NG/Handler/ZimbraPreAuth.pm       | 13 ++++---------
 1 file changed, 4 insertions(+), 9 deletions(-)

diff --git a/modules/lemonldap-ng-handler/lib/Lemonldap/NG/Handler/ZimbraPreAuth.pm b/modules/lemonldap-ng-handler/lib/Lemonldap/NG/Handler/ZimbraPreAuth.pm
index 7f6fde4db..46dd9eabd 100644
--- a/modules/lemonldap-ng-handler/lib/Lemonldap/NG/Handler/ZimbraPreAuth.pm
+++ b/modules/lemonldap-ng-handler/lib/Lemonldap/NG/Handler/ZimbraPreAuth.pm
@@ -65,7 +65,7 @@ sub run {
     my $ret   = $class->SUPER::run(@_);
 
     # Continue only if user is authorized
-    return $ret unless $ret eq OK;
+    return $ret unless ( $ret == OK );
 
     # Get current URI
     my $args = $r->args;
@@ -118,15 +118,10 @@ sub _buildZimbraPreAuthUrl {
         'debug' );
 
     # Build PreAuth URL
-    my $zimbra_url;
-    $zimbra_url .= $url;
-    $zimbra_url .= '?account=' . $account;
-    $zimbra_url .= '&by=' . $by;
-    $zimbra_url .= '&timestamp=' . $timestamp;
-    $zimbra_url .= '&expires=' . $expires;
-    $zimbra_url .= '&preauth=' . $computed_value;
+    my $zimbra_url =
+"$url?account=$account&by=$by&timestamp=$timestamp&expires=$expires&preauth=$computed_value";
 
-    $class->lmLog( "Build Zimbra URL $zimbra_url", 'debug' );
+    $class->lmLog( "Build Zimbra URL: $zimbra_url", 'debug' );
 
     return $zimbra_url;
 }