From 0769967407a803243ff7f4dcbfb99646d2fb813d Mon Sep 17 00:00:00 2001 From: Xavier Guimard Date: Tue, 12 Jun 2018 17:56:19 +0200 Subject: [PATCH] Fix little warning (#1148) --- .../lib/Lemonldap/NG/Portal/2F/U2F.pm | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/lemonldap-ng-portal/lib/Lemonldap/NG/Portal/2F/U2F.pm b/lemonldap-ng-portal/lib/Lemonldap/NG/Portal/2F/U2F.pm index a27ca8d2d..dff0236c8 100644 --- a/lemonldap-ng-portal/lib/Lemonldap/NG/Portal/2F/U2F.pm +++ b/lemonldap-ng-portal/lib/Lemonldap/NG/Portal/2F/U2F.pm @@ -50,9 +50,9 @@ sub init { # Main method sub run { my ( $self, $req, $token ) = @_; - + my $checkLogins = $req->param('checkLogins'); - $self->logger->debug("checkLogins ? $checkLogins"); + $self->logger->debug("checkLogins set") if ($checkLogins); # Check if user is registered if ( my $res = $self->loadUser( $req, $req->sessionInfo ) ) { @@ -92,9 +92,9 @@ sub run { $req, 'u2fcheck', params => { - SKIN => $self->conf->{portalSkin}, - DATA => $data, - TOKEN => $token, + SKIN => $self->conf->{portalSkin}, + DATA => $data, + TOKEN => $token, CHECKLOGINS => $checkLogins } ); @@ -122,7 +122,7 @@ sub verify { unless ( $session->{__ch} and $session->{__ch} eq $challenge ) { $self->userLogger->error( - "U2F challenge changes by user !!! $session->{__ch} / $challenge" +"U2F challenge changes by user !!! $session->{__ch} / $challenge" ); $req->error(PE_BADCREDENTIALS); return $self->fail($req); @@ -207,8 +207,6 @@ sub loadUser { } $self->logger->debug("2F Device(s) found"); - - foreach (@$_2fDevices) { $self->logger->debug("Looking for registered U2F key(s) ..."); if ( $_->{type} eq 'U2F' ) {