dani/lemonldap-ng
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Clean some Dumper usage (#1416)

Browse Source
This commit is contained in:
Xavier Guimard 2018-05-07 17:17:55 +02:00
parent fdf2327b4b
commit 273e84b342
28 changed files with 17 additions and 32 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
lemonldap-ng-common/eg/llng-app.psgi
View File

@ -1,6 +1,5 @@
#!/usr/bin/perl
use Data::Dumper;
use Plack::Builder;
# Basic test app

1
lemonldap-ng-common/lib/Lemonldap/NG/Common/Cli.pm
View File

@ -2,7 +2,6 @@ package Lemonldap::NG::Common::Cli;
use strict;
use Mouse;
use Data::Dumper;
use Lemonldap::NG::Common::Conf;
our $VERSION = '2.0.0';

1
lemonldap-ng-common/lib/Lemonldap/NG/Common/Conf/SAML/Metadata.pm
View File

@ -9,7 +9,6 @@ use strict;
use Mouse;
use Crypt::OpenSSL::RSA;
use Crypt::OpenSSL::X509;
use Data::Dumper;
use HTML::Template;
use MIME::Base64;
use Safe;

2
lemonldap-ng-common/lib/Lemonldap/NG/Common/Conf/Serializer.pm
View File

@ -131,7 +131,7 @@ sub oldUnserialize {
if ( $k =~ $hashParameters and $v ||= {} and not ref($v) ) {
$conf->{$k} = {};
# Value should be a Data::Dumper, else this is an old format
# Value should be a Data::Dumper, else this is an old-old format
if ( defined($v) and $v !~ /^\$/ ) {
$Lemonldap::NG::Common::Conf::msg .=

3
lemonldap-ng-common/lib/Lemonldap/NG/Common/PSGI/Cli/Lib.pm
View File

@ -125,6 +125,7 @@ sub jsonResponse {
or die "PSGI lib has refused my get, aborting";
unless ( $res->[0] == 200 ) {
require Data::Dumper;
$Data::Dumper::Useperl = 1;
print STDERR "Result dump :\n" . Data::Dumper::Dumper($res);
die "Manager lib does not return a 200 code, aborting";
}
@ -139,6 +140,7 @@ sub jsonPostResponse {
or die "PSGI lib has refused my post, aborting";
unless ( $res->[0] == 200 ) {
require Data::Dumper;
$Data::Dumper::Useperl = 1;
print STDERR "Result dump :\n" . Data::Dumper::Dumper($res);
die "Manager lib does not return a 200 code, aborting";
}
@ -153,6 +155,7 @@ sub jsonPutResponse {
or die "PSGI lib has refused my put, aborting";
unless ( $res->[0] == 200 ) {
require Data::Dumper;
$Data::Dumper::Useperl = 1;
print STDERR "Result dump :\n" . Data::Dumper::Dumper($res);
die "Manager lib does not return a 200 code, aborting";
}

2
lemonldap-ng-common/lib/Lemonldap/NG/Common/PSGI/Router.pm
View File

@ -117,8 +117,6 @@ sub handlerAbort {
sub handler {
my ( $self, $req ) = @_;
#print STDERR Dumper($self->routes);use Data::Dumper;
# Reinitialize configuration message
$Lemonldap::NG::Common::Conf::msg = '';

1
lemonldap-ng-handler/lib/Lemonldap/NG/Handler/Lib/Status.pm
View File

@ -6,7 +6,6 @@ package Lemonldap::NG::Handler::Lib::Status;
use strict;
use POSIX qw(setuid setgid);
use JSON qw(to_json);
use Data::Dumper;
our $VERSION = '2.0.0';

1
lemonldap-ng-handler/t/60-Lemonldap-NG-Handler-PSGI.t
View File

@ -1,6 +1,5 @@
use Test::More;
use JSON;
use Data::Dumper;
use MIME::Base64;
require 't/test-psgi-lib.pm';

1
lemonldap-ng-handler/t/61-Lemonldap-NG-Handler-PSGI-Server.t
View File

@ -1,6 +1,5 @@
use Test::More;
use JSON;
use Data::Dumper;
use MIME::Base64;
require 't/test-psgi-lib.pm';

1
lemonldap-ng-handler/t/62-Lemonldap-NG-Handler-Nginx.t
View File

@ -1,6 +1,5 @@
use Test::More;
use JSON;
use Data::Dumper;
use MIME::Base64;
require 't/test-psgi-lib.pm';

1
lemonldap-ng-handler/t/63-Lemonldap-NG-Handler-PSGI-Try.t
View File

@ -1,6 +1,5 @@
use Test::More;
use JSON;
use Data::Dumper;
use MIME::Base64;
require 't/test-psgi-lib.pm';

1
lemonldap-ng-handler/t/64-Lemonldap-NG-Handler-PSGI-DevOps.t
View File

@ -1,6 +1,5 @@
use Test::More;
use JSON;
use Data::Dumper;
use MIME::Base64;
use LWP::UserAgent;

1
lemonldap-ng-handler/t/66-Lemonldap-NG-Handler-PSGI-wildcard.t
View File

@ -1,6 +1,5 @@
use Test::More;
use JSON;
use Data::Dumper;
use MIME::Base64;
BEGIN {

2
lemonldap-ng-handler/t/test-psgi-lib.pm
View File

@ -1,14 +1,12 @@
# Base library for tests
use strict;
use Data::Dumper;
use 5.10.0;
use POSIX 'strftime';
use_ok('Lemonldap::NG::Common::PSGI::Cli::Lib');
our $client;
our $count = 1;
$Data::Dumper::Deparse = 1;
no warnings 'redefine';

1
lemonldap-ng-manager/lib/Lemonldap/NG/Manager/Cli.pm
View File

@ -6,6 +6,7 @@ use Data::Dumper;
use Lemonldap::NG::Common::Conf::ReConstants;
our $VERSION = '2.0.0';
$Data::Dumper::Useperl = 1;
extends('Lemonldap::NG::Manager::Cli::Lib');

1
lemonldap-ng-manager/lib/Lemonldap/NG/Manager/Conf/Parser.pm
View File

@ -79,6 +79,7 @@ sub hdebug {
foreach my $d (@_) {
if ( ref $d ) {
require Data::Dumper;
$Data::Dumper::Useperl = 1;
print STDERR Data::Dumper::Dumper($d);
}
else { print STDERR "$d\n" }

10
lemonldap-ng-manager/scripts/lmConfigEditor
View File

@ -32,7 +32,8 @@ $refConf->{cfgLog} = '';
# Sort keys
$Data::Dumper::Sortkeys = 1;
my $tmp = Dumper($refConf);
$Data::Dumper::Useperl = 1;
my $tmp = Dumper($refConf);
my $refFile = File::Temp->new( UNLINK => 1 );
my $editFile = File::Temp->new( UNLINK => 1 );
@ -68,12 +69,13 @@ if (`diff $refFile $editFile`) {
{
refConf => $refConf,
newConf => $VAR1,
req => 1,
req => 1,
}
);
unless($parser->testNewConf) {
unless ( $parser->testNewConf ) {
print STDERR "Configuration seems to have some errors:\n ";
print STDERR Dumper({errors => $parser->errors,warnings => $parser->warnings});
print STDERR Dumper(
{ errors => $parser->errors, warnings => $parser->warnings } );
print STDERR "Are you sure you want to write it ? (yes/no) ";
my $resp = <STDIN>;
die "Aborted" unless $resp =~ /^yes$/i;

1
lemonldap-ng-manager/t/03-HTML-forms.t
View File

@ -3,7 +3,6 @@
use Test::More;
use strict;
use Data::Dumper;
my $formDir = 'site/htdocs/static/forms';

1
lemonldap-ng-manager/t/05-rest-api.t
View File

@ -43,7 +43,6 @@ foreach my $query (@bad) {
or print STDERR "# Receive a $res->[0] code";
my $href;
#print STDERR Dumper($res->[2]);use Data::Dumper;
ok( $href = from_json( $res->[2]->[0] ), 'Response is JSON' );
ok( $href->{error}, "Receive an explanation message ($href->{error})" );
count(3);

2
lemonldap-ng-manager/t/06-rest-api.t
View File

@ -29,6 +29,4 @@ ok( $res->[0] == 200, "Result code is 200" );
ok( $key = from_json( $res->[2]->[0] ), 'Response is JSON' );
count(3);
#print STDERR Dumper($key);use Data::Dumper;
done_testing( count() );

1
lemonldap-ng-manager/t/10-save-unchanged-conf.t
View File

@ -3,7 +3,6 @@
use Test::More;
use strict;
use JSON;
use Data::Dumper;
require 't/test-lib.pm';
my @struct =

1
lemonldap-ng-manager/t/12-save-changed-conf.t
View File

@ -4,7 +4,6 @@
use Test::More;
use strict;
use JSON;
use Data::Dumper;
require 't/test-lib.pm';
my $struct = 't/jsonfiles/12-modified.json';

1
lemonldap-ng-manager/t/14-bad-changes-in-conf.t
View File

@ -3,7 +3,6 @@
use Test::More;
use strict;
use JSON;
use Data::Dumper;
require 't/test-lib.pm';
my $struct = 't/jsonfiles/14-bad.json';

1
lemonldap-ng-manager/t/15-combination.t
View File

@ -3,7 +3,6 @@
use Test::More;
use strict;
use JSON;
use Data::Dumper;
require 't/test-lib.pm';
my $struct = 't/jsonfiles/15-combination.json';

1
lemonldap-ng-manager/t/80-attributes.t
View File

@ -3,7 +3,6 @@
use strict;
use Test::More;
use Data::Dumper;
# CONSTANTS

1
lemonldap-ng-manager/t/test-lib.pm
View File

@ -1,7 +1,6 @@
# Base library for tests
use strict;
use Data::Dumper;
use 5.10.0;
use_ok('Lemonldap::NG::Manager::Cli::Lib');

3
lemonldap-ng-portal/lib/Lemonldap/NG/Portal/Main/Run.pm
View File

@ -679,7 +679,8 @@ sub cookie {
sub _dump {
my ( $self, $variable ) = @_;
require Data::Dumper;
$Data::Dumper::Indent = 0;
$Data::Dumper::Indent = 0;
$Data::Dumper::Useperl = 1;
$self->logger->debug( "Dump: " . Data::Dumper::Dumper($variable) );
return;
}

5
lemonldap-ng-portal/t/test-lib.pm
View File

@ -3,7 +3,6 @@ package main;
use strict;
use Data::Dumper;
$Data::Dumper::Sortkeys = 1;
use LWP::UserAgent;
use URI::Escape;
use 5.10.0;
@ -15,7 +14,9 @@ BEGIN {
}
our $count = 1;
$Data::Dumper::Deparse = 1;
$Data::Dumper::Deparse = 1;
$Data::Dumper::Sortkeys = 1;
$Data::Dumper::Useperl = 1;
my $ini;
sub count {