From 372b95fba91aedaf18c7b2541305b8a0c7fbfd6d Mon Sep 17 00:00:00 2001 From: Christophe Maudoux Date: Sat, 23 May 2020 23:43:06 +0200 Subject: [PATCH] Improve unit test (#2212) --- .../t/68-Impersonation-with-UnrestrictedUser.t | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/lemonldap-ng-portal/t/68-Impersonation-with-UnrestrictedUser.t b/lemonldap-ng-portal/t/68-Impersonation-with-UnrestrictedUser.t index ba03d2ba6..ebcb371bd 100644 --- a/lemonldap-ng-portal/t/68-Impersonation-with-UnrestrictedUser.t +++ b/lemonldap-ng-portal/t/68-Impersonation-with-UnrestrictedUser.t @@ -16,7 +16,7 @@ my $client = LLNG::Manager::Test->new( { loginHistoryEnabled => 0, brutForceProtection => 0, portalMainLogo => 'common/logos/logo_llng_old.png', - requireToken => 0, + requireToken => 1, impersonationRule => 1, impersonationIdRule => '$uid ne "msmith"', impersonationUnrestrictedUsersRule => '$uid eq "dwho"', @@ -28,7 +28,7 @@ my $client = LLNG::Manager::Test->new( { ok( $res = $client->_get( '/', accept => 'text/html' ), 'Get Menu', ); count(1); my ( $host, $url, $query ) = - expectForm( $res, '#', undef, 'user', 'password', 'spoofId' ); + expectForm( $res, '#', undef, 'user', 'password', 'spoofId', 'token' ); $query =~ s/user=/user=rtyler/; $query =~ s/password=/password=rtyler/; @@ -59,8 +59,8 @@ $client->logout($id); ## Try to Impersonate a forbidden identity ok( $res = $client->_get( '/', accept => 'text/html' ), 'Get Menu', ); count(1); -my ( $host, $url, $query ) = - expectForm( $res, '#', undef, 'user', 'password', 'spoofId' ); +( $host, $url, $query ) = + expectForm( $res, '#', undef, 'user', 'password', 'spoofId', 'token' ); $query =~ s/user=/user=rtyler/; $query =~ s/password=/password=rtyler/; @@ -83,10 +83,8 @@ m%
%, count(2); ## Try to Impersonate a forbidden identity with an Unrestricted user -ok( $res = $client->_get( '/', accept => 'text/html' ), 'Get Menu', ); -count(1); ( $host, $url, $query ) = - expectForm( $res, '#', undef, 'user', 'password', 'spoofId' ); + expectForm( $res, '#', undef, 'user', 'password', 'spoofId', 'token' ); $query =~ s/user=/user=dwho/; $query =~ s/password=/password=dwho/;