dani/lemonldap-ng
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Do not set SAML relaystate if there are no data to store (Lemonldap-524)

Browse Source
This commit is contained in:
François-Xavier Deltombe 2012-09-06 10:56:05 +00:00
parent 495401756c
commit 29a97450d8
1 changed files with 14 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
lemonldap-ng-portal/lib/Lemonldap/NG/Portal/_SAML.pm
View File

@ -792,13 +792,10 @@ sub createAuthnRequest {
}
# Set RelayState
my $infos;
foreach (qw /urldc checkLogins/) {
$infos->{$_} = $self->{$_} if $self->{$_};
if (my $relaystate = $self->storeRelayState(qw /urldc checkLogins/)) {
$login->msg_relayState($relaystate);
$self->lmLog( "Set $relaystate in RelayState", 'debug' );
}
my $relaystate = $self->storeRelayState($infos);
$login->msg_relayState($relaystate);
$self->lmLog( "Set $relaystate in RelayState", 'debug' );
# Customize request
my $request = $login->request();
@ -1163,7 +1160,14 @@ sub acceptSSO {
# corresponding session_id
# @param infos HASH reference of information
sub storeRelayState {
my ( $self, $infos ) = splice @_;
my ( $self, @data ) = splice @_;
# check if there are data to store
my $infos;
foreach (@data) {
$infos->{$_} = $self->{$_} if $self->{$_};
}
return unless ($infos);
# Create relaystate session
my $samlSessionInfo = $self->getSamlSession();
@ -1365,13 +1369,10 @@ sub createLogoutRequest {
}
# Set RelayState
my $infos;
foreach (qw /urldc checkLogins/) {
$infos->{$_} = $self->{$_} if $self->{$_};
if (my $relaystate = $self->storeRelayState(qw /urldc/)) {
$logout->msg_relayState($relaystate);
$self->lmLog( "Set $relaystate in RelayState", 'debug' );
}
my $relaystate = $self->storeRelayState($infos);
$logout->msg_relayState($relaystate);
$self->lmLog( "Set $relaystate in RelayState", 'debug' );
# Signature
if ( $signSLOMessage == 0 ) {