dani/lemonldap-ng
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Access control has been broken in r4353

Browse Source
This commit is contained in:
Xavier Guimard 2016-02-09 22:17:39 +00:00
parent 9aab3bfb70
commit 2dc1750ce7
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
lemonldap-ng-handler/lib/Lemonldap/NG/Handler/PSGI/Base.pm
View File

@ -7,6 +7,7 @@ use Lemonldap::NG::Handler::SharedConf qw(:tsv :variables :jailSharedVars);
our $VERSION = '1.9.0';
has protection => ( is => 'rw', isa => 'Str' );
has rule => ( is => 'rw', isa => 'Str' );
## @method boolean init($args)
# Initalize main handler
@ -24,6 +25,9 @@ sub init {
"Unable to protect this app ($Lemonldap::NG::Common::Conf::msg)");
return 0;
}
my $rule = $self->{protection} || $localConfig->{protection} || '';
$self->rule(
$rule eq 'authenticate' ? 1 : $rule eq 'manager' ? '' : $rule );
return 1;
}
@ -35,11 +39,8 @@ sub _run {
my $self = shift;
# Override _run() only if protection != 'none'
my $rule = $self->{protection} || $localConfig->{protection} || 'manager';
if ( $rule ne 'none' ) {
if ( $self->rule ne 'none' ) {
$self->lmLog( 'PSGI app is protected', 'debug' );
$rule =
$rule eq "authenticate" ? "accept" : $rule eq "manager" ? "" : $rule;
# Handle requests
# Developers, be careful: Only this part is executed at each request
@ -75,8 +76,7 @@ sub _run {
sub _authAndTrace {
my ( $self, $req ) = @_;
Lemonldap::NG::Handler::API->newRequest($req);
my $res = Lemonldap::NG::Handler::SharedConf->run( $self->{protection}
|| $localConfig->{protection} );
my $res = Lemonldap::NG::Handler::SharedConf->run( $self->{rule} );
$req->userData($datas) if ($datas);
if ( $res < 300 ) {