dani/lemonldap-ng
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Skip bad GrantSession rules & Improve unit test (#2201)

Browse Source
This commit is contained in:
Christophe Maudoux 2020-05-10 14:16:21 +02:00
parent 4688c2debc
commit 2ecd0b18a8
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lemonldap-ng-portal/lib/Lemonldap/NG/Portal/Plugins/GrantSession.pm
View File

@ -28,8 +28,9 @@ sub init {
$hd->substitute( $self->conf->{grantSessionRules}->{$_} ) );
unless ($rule) {
my $error = $hd->tsv->{jail}->error || '???';
$self->error("Bad grantSession rule -> $error");
return 0;
$self->logger->error("Bad grantSession rule -> $error");
$self->logger->debug("Skipping GrantSession rule \"$_\"");
next;
}
$self->rules->{$_} = $rule;
}

1
lemonldap-ng-portal/t/61-GrantSession.t
View File

@ -20,6 +20,7 @@ my $client = LLNG::Manager::Test->new( {
'Rtyler_Allowed##rule3' => '$uid eq "rtyler"',
'##rule2' => '$uid ne "msmith"',
'##rule4' => '$uid ne "jdoe"',
'##bad_rule' => '$uid n "jdoe"',
}
}
}