dani/lemonldap-ng
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Improve TOTP error reporting (#2541)

Browse Source
This commit is contained in:
Maxime Besson 2021-06-15 18:07:03 +02:00
parent 9f1f185a15
commit 3c37565eb9
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
lemonldap-ng-portal/lib/Lemonldap/NG/Portal/2F/Register/TOTP.pm
View File

@ -36,8 +36,7 @@ sub init {
sub run {
my ( $self, $req, $action ) = @_;
my $user = $req->userData->{ $self->conf->{whatToTrace} };
return $self->p->sendError( $req,
'No ' . $self->conf->{whatToTrace} . ' found in user data', 500 )
return $self->p->sendError( $req, 'PE82', 400 )
unless $user;
# Check if TOTP can be updated
@ -118,7 +117,7 @@ sub run {
};
if ($@) {
$self->logger->error("Corrupted session (_2fDevices): $@");
return $self->p->sendError( $req, "Corrupted session", 500 );
return $self->p->sendError( $req, "serverError", 500 );
}
}
else {
@ -192,7 +191,7 @@ sub run {
};
if ($@) {
$self->logger->error("Corrupted session (_2fDevices): $@");
return $self->p->sendError( $req, "Corrupted session", 500 );
return $self->p->sendError( $req, "serverError", 500 );
}
}
@ -216,7 +215,8 @@ sub run {
if ($secret) {
return $self->p->sendError( $req, 'totpExistingKey', 200 );
} else {
}
else {
$secret = $self->newSecret;
$self->logger->debug("Generating new secret = $secret");
$nk = 1;
@ -271,7 +271,7 @@ sub run {
};
if ($@) {
$self->logger->error("Corrupted session (_2fDevices): $@");
return $self->p->sendError( $req, "Corrupted session", 500 );
return $self->p->sendError( $req, "serverError", 500 );
}
}
else {