Improve TOTP error reporting (#2541)
This commit is contained in:
parent
9f1f185a15
commit
3c37565eb9
|
@ -36,8 +36,7 @@ sub init {
|
||||||
sub run {
|
sub run {
|
||||||
my ( $self, $req, $action ) = @_;
|
my ( $self, $req, $action ) = @_;
|
||||||
my $user = $req->userData->{ $self->conf->{whatToTrace} };
|
my $user = $req->userData->{ $self->conf->{whatToTrace} };
|
||||||
return $self->p->sendError( $req,
|
return $self->p->sendError( $req, 'PE82', 400 )
|
||||||
'No ' . $self->conf->{whatToTrace} . ' found in user data', 500 )
|
|
||||||
unless $user;
|
unless $user;
|
||||||
|
|
||||||
# Check if TOTP can be updated
|
# Check if TOTP can be updated
|
||||||
|
@ -118,7 +117,7 @@ sub run {
|
||||||
};
|
};
|
||||||
if ($@) {
|
if ($@) {
|
||||||
$self->logger->error("Corrupted session (_2fDevices): $@");
|
$self->logger->error("Corrupted session (_2fDevices): $@");
|
||||||
return $self->p->sendError( $req, "Corrupted session", 500 );
|
return $self->p->sendError( $req, "serverError", 500 );
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
else {
|
else {
|
||||||
|
@ -192,7 +191,7 @@ sub run {
|
||||||
};
|
};
|
||||||
if ($@) {
|
if ($@) {
|
||||||
$self->logger->error("Corrupted session (_2fDevices): $@");
|
$self->logger->error("Corrupted session (_2fDevices): $@");
|
||||||
return $self->p->sendError( $req, "Corrupted session", 500 );
|
return $self->p->sendError( $req, "serverError", 500 );
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -216,7 +215,8 @@ sub run {
|
||||||
|
|
||||||
if ($secret) {
|
if ($secret) {
|
||||||
return $self->p->sendError( $req, 'totpExistingKey', 200 );
|
return $self->p->sendError( $req, 'totpExistingKey', 200 );
|
||||||
} else {
|
}
|
||||||
|
else {
|
||||||
$secret = $self->newSecret;
|
$secret = $self->newSecret;
|
||||||
$self->logger->debug("Generating new secret = $secret");
|
$self->logger->debug("Generating new secret = $secret");
|
||||||
$nk = 1;
|
$nk = 1;
|
||||||
|
@ -271,7 +271,7 @@ sub run {
|
||||||
};
|
};
|
||||||
if ($@) {
|
if ($@) {
|
||||||
$self->logger->error("Corrupted session (_2fDevices): $@");
|
$self->logger->error("Corrupted session (_2fDevices): $@");
|
||||||
return $self->p->sendError( $req, "Corrupted session", 500 );
|
return $self->p->sendError( $req, "serverError", 500 );
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
else {
|
else {
|
||||||
|
|
Loading…
Reference in New Issue
Block a user