dani
/
lemonldap-ng
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

manager: Adapt html to stricter rules in angularjs >= 1.8.0 

label and textarea elements in XHTML must have a matching closing tag
for strict XHTML conformity; when upgrading to angularjs 1.8.0, this
became mandatory even when used with angular because of some potential
XSS issue.

Without this change, the rendering of the modal save form of the manager
web interface will "break" halfway through, and only the text "Summary"
is visible under the "Saving configuration" header. (This is similar to
what is described in #2197, but with that fixed applied.)

Reference: https://docs.angularjs.org/guide/migration#migrating-from-1-7-to-1-8
This commit is contained in:
Olof Johansson 2020-06-30 15:57:20 +02:00
parent f78b2bfa16
commit 5571e22a55
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lemonldap-ng-manager/site/templates/manager.tpl
View File

@ -177,8 +177,8 @@
</div>
<div id="sbody" class="modal-body">
<div class="input-group maxw">
<label id="slabel" class="input-group-addon" for="longtextinput" trspan="cfgLog"/>
<textarea id="longtextinput" rows="5" class="form-control" ng-model="result" aria-describedby="slabel" />
<label id="slabel" class="input-group-addon" for="longtextinput" trspan="cfgLog"></label>
<textarea id="longtextinput" rows="5" class="form-control" ng-model="result" aria-describedby="slabel"></textarea>
</div>
</div>
<div class="modal-footer">