dani/lemonldap-ng
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Eval() in init() (#1413)

Browse Source
This commit is contained in:
Xavier Guimard 2018-04-26 07:38:17 +02:00
parent 2d388c174a
commit 6605ea1857
1 changed files with 18 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
lemonldap-ng-portal/lib/Lemonldap/NG/Portal/Lib/Choice.pm
View File

@ -10,6 +10,8 @@ our $VERSION = '2.0.0';
has modules => ( is => 'rw', default => sub { {} } );
has rules => ( is => 'rw', default => sub { {} } );
has type => ( is => 'rw' );
# INITIALIZATION
@ -47,6 +49,20 @@ sub init {
"Choice: unable to load $name, disabling it: " . $self->error );
$self->error('');
}
# Display conditions
my $safe = Safe->new;
if ( my $cond = $mods[4] ) {
my $self->rules->{$name} =
$safe->reval("sub{my(\$env)=\@_;return ($cond)}");
if ($@) {
$self->logger->error("Bad condition $cond: $@");
return 0;
}
}
else {
$self->rules->{$name} = sub { 1 };
}
}
unless ( keys %{ $self->modules } ) {
$self->error('Choice: no available modules found, aborting');
@ -90,7 +106,6 @@ package Lemonldap::NG::Portal::Main;
sub _buildAuthLoop {
my ( $self, $req ) = @_;
my @authLoop;
my $safe = Safe->new;
# Test authentication choices
unless ( ref $self->conf->{authChoiceModules} eq 'HASH' ) {
@ -115,9 +130,9 @@ sub _buildAuthLoop {
# Find modules associated to authChoice
my ( $auth, $userDB, $passwordDB, $url, $condition ) =
split( /[;\|]/, $self->conf->{authChoiceModules}->{$_} );
split( /[;\|]/, $self->conf->{authChoiceModules}->{$name} );
if ( defined $condition and !$safe->reval($condition) ) {
unless ( $self->rules->{$name}->( $req->env ) ) {
$self->logger->debug(
"Condition returns false, authentication choice $name will not be displayed"
);