dani/lemonldap-ng
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use system() for security in External2F plugin (#1015)

Browse Source
This commit is contained in:
Xavier Guimard 2017-03-22 22:46:49 +00:00
parent 0538ad1cee
commit 6a76cf1e17
1 changed files with 16 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
lemonldap-ng-portal/lib/Lemonldap/NG/Portal/Plugins/External2F.pm
View File

@ -52,11 +52,7 @@ sub run {
my ( $self, $req ) = @_;
# Prepare command and launch it
my $cmd = $self->conf->{ext2FSendCommand};
$cmd =~ s#\$(\w+)#$req->{sessionInfo}->{$1} // ''#ge;
my $err = `$cmd 2>&1 1>/dev/null`;
$self->logger->error($err) if ( length $err );
if ($?) {
if ( $self->launch( $req->sessionInfo, $self->conf->{ext2FSendCommand} ) ) {
return $self->p->do( $req, [ sub { PE_ERROR } ] );
}
@ -102,12 +98,7 @@ sub verify {
}
# Prepare command and launch it
my $cmd = $self->conf->{ext2FValidateCommand};
$cmd =~ s#\$code\b#$code#g;
$cmd =~ s#\$(\w+)#$session->{$1} // ''#ge;
my $err = `$cmd 2>&1 1>/dev/null`;
$self->userLogger->error($err) if ( length $err );
if ($?) {
if ( $self->launch( $session, $self->conf->{ext2FValidateCommand}, $code ) ) {
return $self->p->do( $req, [ sub { PE_BADCREDENTIALS } ] );
}
$req->sessionInfo($session);
@ -122,4 +113,18 @@ sub verify {
return $self->p->do( $req, [ sub { PE_OK } ] );
}
# system() is used with an array to avoid shell injection
sub launch {
my ( $self, $session, $command, $code ) = @_;
my @args;
foreach ( split( /\s+/, $command ) ) {
if ( defined $code ) {
s#\$code\b#$code#g;
}
s#\$(\w+)#$session->{$1} // ''#ge;
push @args, $_;
}
return system @args;
}
1;