From 7b0990addd81bfc6ba47cce0512b37cdbefd723c Mon Sep 17 00:00:00 2001 From: Maxime Besson Date: Mon, 14 Jun 2021 15:52:50 +0200 Subject: [PATCH] Remove totp options from code (#2541) --- .../Lemonldap/NG/Portal/2F/Register/TOTP.pm | 18 +++--------------- 1 file changed, 3 insertions(+), 15 deletions(-) diff --git a/lemonldap-ng-portal/lib/Lemonldap/NG/Portal/2F/Register/TOTP.pm b/lemonldap-ng-portal/lib/Lemonldap/NG/Portal/2F/Register/TOTP.pm index cb738a3ad..b3894669a 100644 --- a/lemonldap-ng-portal/lib/Lemonldap/NG/Portal/2F/Register/TOTP.pm +++ b/lemonldap-ng-portal/lib/Lemonldap/NG/Portal/2F/Register/TOTP.pm @@ -214,26 +214,14 @@ sub run { $self->logger->debug("Reading TOTP secret if exists..."); $secret = $_->{_secret} foreach (@totp2f); - if ( ( $req->param('newkey') and $self->conf->{totp2fUserCanChangeKey} ) - or not $secret ) - { + if ($secret) { + return $self->p->sendError( $req, 'totpExistingKey', 200 ); + } else { $secret = $self->newSecret; $self->logger->debug("Generating new secret = $secret"); $nk = 1; } - elsif ( $req->param('newkey') ) { - return $self->p->sendError( $req, 'notAuthorized', 200 ); - } - - elsif ( $self->conf->{totp2fDisplayExistingSecret} ) { - $self->logger->debug("User secret = $secret"); - } - - else { - return $self->p->sendError( $req, 'totpExistingKey', 200 ); - } - # Secret is stored in a token: we choose to not accept secret returned # by Ajax request to avoid some attacks my $token = $self->ott->createToken( {