dani/lemonldap-ng
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Securize SQL queries

Browse Source
This commit is contained in:
Xavier Guimard 2013-07-12 07:58:46 +00:00
parent 1fbedb00e7
commit 8bfd7925ce
3 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lemonldap-ng-common/lib/Lemonldap/NG/Common/Conf/CDBI.pm
View File

@ -29,7 +29,8 @@ sub load {
my ( $self, $cfgNum, $fields ) = @_;
$fields = $fields ? join( ",", @$fields ) : '*';
my $row = $self->_dbh->selectrow_arrayref(
"SELECT data from " . $self->{dbiTable} . " WHERE cfgNum=$cfgNum" );
"SELECT data from " . $self->{dbiTable} . " WHERE cfgNum=?",
{}, $cfgNum );
unless ($row) {
$self->logError;
return 0;

3
lemonldap-ng-common/lib/Lemonldap/NG/Common/Conf/DBI.pm
View File

@ -33,7 +33,8 @@ sub load {
my ( $self, $cfgNum, $fields ) = @_;
$fields = $fields ? join( ",", @$fields ) : '*';
my $row = $self->_dbh->selectrow_hashref(
"SELECT $fields from " . $self->{dbiTable} . " WHERE cfgNum=$cfgNum" );
"SELECT $fields from " . $self->{dbiTable} . " WHERE cfgNum=?",
{}, $cfgNum );
unless ($row) {
$self->logError;
return 0;

4
lemonldap-ng-common/lib/Lemonldap/NG/Common/Conf/_DBI.pm
View File

@ -114,8 +114,8 @@ sub unlock {
sub delete {
my ( $self, $cfgNum ) = @_;
$self->_dbh->do(
"DELETE from " . $self->{dbiTable} . " WHERE cfgNum=$cfgNum" );
$self->_dbh->do( "DELETE from " . $self->{dbiTable} . " WHERE cfgNum=?",
{}, $cfgNum );
}
sub logError {