dani/lemonldap-ng
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Check display and prompt request parameters for unauthenticated user (#184)

Browse Source
This commit is contained in:
Clément Oudot 2015-03-25 10:54:00 +00:00
parent c07f698bdb
commit c6589a7f7b
2 changed files with 70 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

58
lemonldap-ng-portal/lib/Lemonldap/NG/Portal/IssuerDBOpenIDConnect.pm
View File

@ -55,6 +55,52 @@ sub issuerForUnAuthUser {
$self->getHiddenFormValue($param) || $self->param($param) );
}
# Detect requested flow
my $response_type = $self->param("response_type");
my $flow = $self->getFlowType($response_type);
unless ($flow) {
$self->lmLog( "Unknown response type: $response_type", 'error' );
return PE_ERROR;
}
$self->lmLog(
"OIDC $flow flow requested (response type: $response_type)",
'debug' );
# Check redirect_uri
unless ( $self->param("redirect_uri") ) {
$self->lmLog( "Redirect URI is required", 'error' );
return PE_ERROR;
}
# Check display
my $display = $self->param("display");
if ( $display eq "page" ) {
$self->lmLog( "Display type page will be used", 'debug' );
}
else {
$self->lmLog(
"Display type $display not supported, display type page will be used",
'debug'
);
}
# Check prompt
my $prompt = $self->param("prompt");
if ( $prompt eq "none" ) {
$self->lmLog(
"Prompt type none requested, but user needs to authenticate",
'error' );
$self->returnRedirectError(
$self->param("redirect_uri"),
"login_required",
"Prompt type none requested",
undef,
$self->param("state"),
( $flow ne "authorizationcode" )
);
}
}
# TOKEN
@ -314,17 +360,7 @@ sub issuerForAuthUser {
# Detect requested flow
my $response_type = $oidc_request->{'response_type'};
my $response_types = {
"code" => "authorizationcode",
"id_token" => "implicit",
"id_token token" => "implicit",
"code id_token" => "hybrid",
"code token" => "hybrid",
"code id_token token" => "hybrid",
};
my $flow = $response_types->{$response_type};
my $flow = $self->getFlowType($response_type);
unless ($flow) {
$self->lmLog( "Unknown response type: $response_type", 'error' );

23
lemonldap-ng-portal/lib/Lemonldap/NG/Portal/_OpenIDConnect.pm
View File

@ -1140,6 +1140,25 @@ sub createIDToken {
return;
}
## @method String getFlowType(String response_type)
# Return flow type
# @param response_type Response type
# @return String flow
sub getFlowType {
my ( $self, $response_type ) = splice @_;
my $response_types = {
"code" => "authorizationcode",
"id_token" => "implicit",
"id_token token" => "implicit",
"code id_token" => "hybrid",
"code token" => "hybrid",
"code id_token token" => "hybrid",
};
return $response_types->{$response_type};
}
1;
__END__
@ -1277,6 +1296,10 @@ Return Hash of UserInfo data
Return ID Token
=head2 getFlowType
Return flow type
=head1 SEE ALSO
L<Lemonldap::NG::Portal::AuthOpenIDConnect>, L<Lemonldap::NG::Portal::UserDBOpenIDConnect>