From e05a167937853697e74f90af8e961f11773a5026 Mon Sep 17 00:00:00 2001
From: Maxime Besson <maxime.besson@worteks.com>
Date: Mon, 21 Dec 2020 11:04:12 +0100
Subject: [PATCH] Handle missing nameid (#2420)

---
 lemonldap-ng-portal/lib/Lemonldap/NG/Portal/Auth/SAML.pm | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/lemonldap-ng-portal/lib/Lemonldap/NG/Portal/Auth/SAML.pm b/lemonldap-ng-portal/lib/Lemonldap/NG/Portal/Auth/SAML.pm
index 027e44219..62c7d9ee3 100644
--- a/lemonldap-ng-portal/lib/Lemonldap/NG/Portal/Auth/SAML.pm
+++ b/lemonldap-ng-portal/lib/Lemonldap/NG/Portal/Auth/SAML.pm
@@ -297,9 +297,13 @@ sub extractFormInfo {
             }
 
             # Get NameID
-            my $nameid         = $login->nameIdentifier;
-            my $nameid_content = $nameid->content;
+            my $nameid = $login->nameIdentifier;
+            unless ($nameid) {
+                $self->userLogger->error("No NameID element found");
+                return PE_SAML_SSO_ERROR;
+            }
 
+            my $nameid_content = $nameid->content;
             unless ($nameid_content) {
                 $self->userLogger->error("No NameID value found");
                 return PE_SAML_SSO_ERROR;