From e39f67290ce2ba39b332c95d0a224a9765f30416 Mon Sep 17 00:00:00 2001 From: Maxime Besson Date: Wed, 29 Jan 2020 08:01:44 +0100 Subject: [PATCH] Fix unit test for #321 with old perl --- .../t/60-Lemonldap-NG-Handler-PSGI.t | 23 ++++++++++++------- 1 file changed, 15 insertions(+), 8 deletions(-) diff --git a/lemonldap-ng-handler/t/60-Lemonldap-NG-Handler-PSGI.t b/lemonldap-ng-handler/t/60-Lemonldap-NG-Handler-PSGI.t index 14dc7100f..f42555e13 100644 --- a/lemonldap-ng-handler/t/60-Lemonldap-NG-Handler-PSGI.t +++ b/lemonldap-ng-handler/t/60-Lemonldap-NG-Handler-PSGI.t @@ -36,10 +36,14 @@ ok( $res = $client->_get( '/', undef, undef, "lemonldap=$sessionId" ), ok( $res->[0] == 200, 'Code is 200' ) or explain( $res, 200 ); count(2); -ok( $res = $client->_get( '/user_dwho/', undef, undef, "lemonldap=$sessionId" ), - 'Regexp query' ); -ok( $res->[0] == 200, 'Code is 200' ) or explain( $res, 200 ); -count(2); + +SKIP: { + skip "Regexp match in rules only supported in recent Perl", 0 unless $^V ge v5.25.7; + ok( $res = $client->_get( '/user_dwho/', undef, undef, "lemonldap=$sessionId" ), + 'Regexp query' ); + ok( $res->[0] == 200, 'Code is 200' ) or explain( $res, 200 ); + count(2); + }; # Request an URI protected by custom function -> allowed ok( @@ -92,11 +96,14 @@ ok( $res = $client->_get( '/AuthWeak', undef, undef, "lemonldap=$sessionId" ), ok( $res->[0] == 200, 'Code is 200' ) or explain( $res, 200 ); count(2); -ok( $res = $client->_get( '/user_rtyler/', undef, undef, "lemonldap=$sessionId" ), - 'Regexp deny query' ); -ok( $res->[0] == 403, 'Code is 403' ) or explain( $res, 403 ); +SKIP: { + skip "Regexp match in rules only supported in recent Perl", 0 unless $^V ge v5.25.7; + ok( $res = $client->_get( '/user_rtyler/', undef, undef, "lemonldap=$sessionId" ), + 'Regexp deny query' ); + ok( $res->[0] == 403, 'Code is 403' ) or explain( $res, 403 ); + count(2); +} -count(2); # Required AuthnLevel = 5 ok(