From ed56a171b9e514c07b366cd9d179d34178b016a7 Mon Sep 17 00:00:00 2001 From: Christophe Maudoux Date: Thu, 30 Sep 2021 23:13:04 +0200 Subject: [PATCH] Tidy (#2620) --- .../lib/Lemonldap/NG/Portal/Lib/Net/LDAP.pm | 22 ++++++++++--------- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/lemonldap-ng-portal/lib/Lemonldap/NG/Portal/Lib/Net/LDAP.pm b/lemonldap-ng-portal/lib/Lemonldap/NG/Portal/Lib/Net/LDAP.pm index 4e33c3270..5a00bf768 100644 --- a/lemonldap-ng-portal/lib/Lemonldap/NG/Portal/Lib/Net/LDAP.pm +++ b/lemonldap-ng-portal/lib/Lemonldap/NG/Portal/Lib/Net/LDAP.pm @@ -14,7 +14,7 @@ use Scalar::Util 'weaken'; use IO::Socket::Timeout; use utf8; -our $VERSION = '2.0.14'; +our $VERSION = '2.0.14'; # INITIALIZATION @@ -138,8 +138,9 @@ sub bind { if ( $mesg->code ) { my ($resp) = $mesg->control("1.3.6.1.4.1.42.2.27.8.5.1"); + # Check for ppolicy error - my $pp_error = $resp->pp_error if (defined($resp)); + my $pp_error = $resp->pp_error if ( defined($resp) ); if ( defined $pp_error ) { my $ppolicy_error = [ "password expired", @@ -150,18 +151,20 @@ sub bind { "insufficient password quality", "password too short", "password too young", - "password in history", + "password in history" ]->[$pp_error]; - $self->{portal}->logger->error( "Error when binding to LDAP server: ". $mesg->error. - " | extended ppolicy control response error: ".$ppolicy_error ); + $self->{portal} + ->logger->error( "Error when binding to LDAP server: " + . $mesg->error + . " | extended ppolicy control response error: $ppolicy_error" + ); } - else - { - $self->{portal}->logger->error( "Error when binding to LDAP server: ". $mesg->error ); + else { + $self->{portal}->logger->error( + "Error when binding to LDAP server: " . $mesg->error ); } } - } else { $mesg = $self->SUPER::bind(); @@ -169,7 +172,6 @@ sub bind { return $mesg; } - ## @method Net::LDAP::Message unbind() # Reimplementation of Net::LDAP::unbind() to force call to disconnect() # @return Net::LDAP::Message