dani/lemonldap-ng
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use OTT for state token (#(595)

Browse Source
This commit is contained in:
Xavier Guimard 2017-03-18 19:51:00 +00:00
parent 1a65e9a0fe
commit f1ac524c24
2 changed files with 5 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
lemonldap-ng-portal/lib/Lemonldap/NG/Portal/Lib/OpenIDConnect.pm
View File

@ -55,7 +55,6 @@ has ott => (
lazy => 1,
default => sub {
my $ott = $_[0]->{p}->loadModule('::Lib::OneTimeToken');
$ott->timeout( $_[0]->timeout );
return $ott;
}
);
@ -687,11 +686,7 @@ sub storeState {
$infos->{_utime} = $time + ( $stateTimeout - $timeout );
# Create state session and store infos
my $stateSession = $self->getOpenIDConnectSession( undef, $infos );
return unless $stateSession;
# Return session ID
return $stateSession->id;
return $self->ott->createToken($infos);
}
# Extract state information into $self
@ -701,14 +696,14 @@ sub extractState {
return 0 unless $state;
# Open state session
my $stateSession = $self->getOpenIDConnectSession($state);
my $stateSession = $self->ott->getToken($state);
return 0 unless $stateSession;
# Push values in $self
foreach ( keys %{ $stateSession->data } ) {
foreach ( keys %{ $stateSession } ) {
next if $_ =~ /(type|_session_id|_session_kind|_utime)/;
my $tmp = $stateSession->data->{$_};
my $tmp = $stateSession->{$_};
if (s/^datas_//) {
$req->datas->{$_} = $tmp;
}
@ -720,15 +715,6 @@ sub extractState {
}
}
# Delete state session
if ( $stateSession->remove ) {
$self->logger->debug("State $state was deleted");
}
else {
$self->logger->error("Unable to delete state $state");
$self->logger->error( $stateSession->error );
}
return 1;
}

2
lemonldap-ng-portal/t/37-OIDC-RP-to-SAML-IdP.t
View File

@ -9,7 +9,7 @@ BEGIN {
}
my $maintests = 11;
my $debug = 'debug';
my $debug = 'error';
my ( $idp, $sp, $rp, $res );
my %handlerOR = ( idp => [], sp => [], rp => [] );