dani/lemonldap-ng
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

doc: suggest a better fix for #1864

Browse Source 
We can't do it yet because the issue isn't fixed in versions of Lasso
found in the wild. But someday it will be.
This commit is contained in:
Maxime Besson 2019-09-03 18:12:12 +02:00
parent ef3d6a26c4
commit ff3d4e218c
1 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
lemonldap-ng-portal/lib/Lemonldap/NG/Portal/Lib/SAML.pm
View File

@ -255,6 +255,11 @@ sub loadIDPs {
}
# Add this IDP to Lasso::Server
# TODO: when Lasso issue #35061 is fixed in all distros,
# we could load the metadata into a new LassoProvider, extract the
# parsed-and-decoded entityID from this Provider, and then add the
# Provider into the server with $server->add_provider2, instead of
# decoding HTML entities ourselves below
my $result = $self->addIDP( $self->lassoServer, $idp_metadata );
unless ($result) {
@ -267,6 +272,7 @@ sub loadIDPs {
( $idp_metadata =~ /entityID=(['"])(.+?)\1/si );
# Decode HTML entities from entityID
# TODO: see Lasso comment above
decode_entities($entityID);
my $name = $self->getOrganizationName( $self->lassoServer, $entityID )
@ -356,6 +362,11 @@ sub loadSPs {
}
# Add this SP to Lasso::Server
# TODO: when Lasso issue #35061 is fixed in all distros,
# we could load the metadata into a new LassoProvider, extract the
# parsed-and-decoded entityID from this Provider, and then add the
# Provider into the server with $server->add_provider2, instead of
# decoding HTML entities ourselves below
my $result = $self->addSP( $self->lassoServer, $sp_metadata );
unless ($result) {
@ -367,6 +378,7 @@ sub loadSPs {
my ( $tmp, $entityID ) = ( $sp_metadata =~ /entityID=(['"])(.+?)\1/si );
# Decode HTML entities from entityID
# TODO: see Lasso comment above
decode_entities($entityID);
my $name = $self->getOrganizationName( $self->lassoServer, $entityID )