From f8c0630c80f3f594c63cfa7749761e90e435eb6b Mon Sep 17 00:00:00 2001 From: Ely Deckers Date: Sun, 12 Mar 2023 22:23:56 +0100 Subject: [PATCH 1/2] fix: broken variable initializations php 8.1 --- pfsense_zbx.php | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/pfsense_zbx.php b/pfsense_zbx.php index 5975f50..2773649 100644 --- a/pfsense_zbx.php +++ b/pfsense_zbx.php @@ -859,6 +859,13 @@ function pfz_dhcp_get($valuekey) { $leases_count = count($leases_content); @exec("/usr/sbin/arp -an", $rawdata); + $leases = []; + $pools = []; + + $i = 0; + $l = 0; + $p = 0; + foreach ($leases_content as $lease) { /* split the line by space */ $data = explode(" ", $lease); From b07d9074e98ccbefb1534094caf8b37fdfd404dd Mon Sep 17 00:00:00 2001 From: Ely Deckers Date: Tue, 14 Mar 2023 16:54:26 +0100 Subject: [PATCH 2/2] Fix Speedtest variable initialization --- pfsense_zbx.php | 2 +- pfsense_zbx_rc.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/pfsense_zbx.php b/pfsense_zbx.php index 2773649..0a13f7e 100644 --- a/pfsense_zbx.php +++ b/pfsense_zbx.php @@ -155,7 +155,7 @@ function pfz_interface_speedtest_value($ifname, $value){ $filename = "/tmp/speedtest-$ifname"; if (file_exists($filename)) { - $speedtest_data = json_decode(file_get_contents($filename), true); + $speedtest_data = json_decode(file_get_contents($filename), true) ?? []; if (array_key_exists($value, $speedtest_data)) { if ($subvalue == false) diff --git a/pfsense_zbx_rc.php b/pfsense_zbx_rc.php index 74dda34..9e6d246 100644 --- a/pfsense_zbx_rc.php +++ b/pfsense_zbx_rc.php @@ -671,7 +671,7 @@ class SpeedTest return Util::result(""); } - $speed_test_data = json_decode(file_get_contents($filename), true); + $speed_test_data = json_decode(file_get_contents($filename), true) ?? []; if (!array_key_exists($value, $speed_test_data)) { return Util::result(""); }