From 1368baec846d6d740c7b75f47926856aa4b00ba2 Mon Sep 17 00:00:00 2001
From: Daniel Berteaud <daniel@firewall-services.com>
Date: Fri, 26 Jun 2015 14:38:11 +0200
Subject: [PATCH] Log modified fields when modifying a room conf

---
 vroom.pl | 18 +++++++++++++++++-
 1 file changed, 17 insertions(+), 1 deletion(-)

diff --git a/vroom.pl b/vroom.pl
index 0ba9eb0..395d120 100755
--- a/vroom.pl
+++ b/vroom.pl
@@ -266,7 +266,6 @@ helper get_room_by_id => sub {
 };
 
 # Update a room, take a room object as argument (hashref)
-# TODO: log modified fields
 helper modify_room => sub {
   my $self = shift;
   my ($room) = @_;
@@ -276,6 +275,10 @@ helper modify_room => sub {
   if (!$self->valid_room_name($room->{name})){
     return 0;
   }
+  my $old_room = $self->get_room_by_id($room->{id});
+  if (!$old_room){
+    return 0;
+  }
   if (!$room->{max_members} ||
       ($room->{max_members} > $config->{'rooms.max_members'} && $config->{'rooms.max_members'} > 0)){
     $room->{max_members} = 0;
@@ -306,6 +309,19 @@ helper modify_room => sub {
     $room->{id}
   );
   $self->app->log->info("Room " . $room->{name} ." modified by " . $self->get_name);
+  my $mods = '';
+  foreach my $field (keys %$room){
+    if (($old_room->{$field} // '' ) ne ($room->{$field} // '')){
+      if ($field =~ m/_password$/){
+        $old_room->{$field} = '<hidden>';
+        $room->{$field}     = '<hidden>';
+      }
+      $mods .= $field . ": " . $old_room->{$field} . ' -> ' . $room->{$field} . "\n";
+    }
+  }
+  if ($mods ne ''){
+    $self->app->log->debug("Modified fields:\n$mods");
+  }
   return 1;
 };